orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omalley <...@git.apache.org>
Subject [GitHub] orc pull request #138: ORC-91: Use hdfs v-blocks instead of zero-padding str...
Date Fri, 04 Aug 2017 21:34:08 GMT
Github user omalley commented on a diff in the pull request:

    https://github.com/apache/orc/pull/138#discussion_r131491100
  
    --- Diff: java/core/src/java/org/apache/orc/impl/HadoopShims.java ---
    @@ -124,6 +126,43 @@
        */
       public TextReaderShim getTextReaderShim(InputStream input) throws IOException;
     
    +  
    +  /** 
    +   * Block filler shim - make sure the DFS blocks ends at this offset.
    +   */
    +  public interface BlockFillerShim {
    --- End diff --
    
    I think it would be better to create a HadoopShims_2_5 that has the simple fill method
and make HadoopShimsCurrent have the full featured one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message