Mailing-List: contact dev-help@orc.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@orc.apache.org
From: xndai <git@git.apache.org>
To: dev@orc.apache.org
Reply-To: dev@orc.apache.org
References: <git-pr-134-orc@git.apache.org>
In-Reply-To: <git-pr-134-orc@git.apache.org>
Subject: [GitHub] orc pull request #134: Orc 17
Content-Type: text/plain
Message-Id: <20170705185634.7AC02DFA84@git1-us-west.apache.org>
Date: Wed,  5 Jul 2017 18:56:34 +0000 (UTC)
archived-at: Wed, 05 Jul 2017 18:56:36 -0000

Github user xndai commented on a diff in the pull request:

    https://github.com/apache/orc/pull/134#discussion_r125728966
  
    --- Diff: c++/src/OrcHdfsFile.cc ---
    @@ -123,17 +123,21 @@ namespace orc {
                   uint64_t length,
                   uint64_t offset) override {
     
    -      size_t last_bytes_read = 0;
    -
           if (!buf) {
             throw ParseError("Buffer is null");
           }
     
           hdfs::Status status;
    -      status = file->PositionRead(buf, static_cast<size_t>(length), static_cast<off_t>(offset), &last_bytes_read);
    -      if(!status.ok()) {
    -        throw ParseError("Error reading the file: " + status.ToString());
    -      }
    +      size_t total_bytes_read = 0;
    +      size_t last_bytes_read = 0;
    +      
    +      do {
    +        status = file->PositionRead(buf, static_cast<size_t>(length) - total_bytes_read, static_cast<off_t>(offset + total_bytes_read), &last_bytes_read);
    --- End diff --
    
    Make sure to wrap on 80 characters.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---