Mailing-List: contact dev-help@orc.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@orc.apache.org
From: AnatoliShein <git@git.apache.org>
To: dev@orc.apache.org
Reply-To: dev@orc.apache.org
References: <git-pr-134-orc@git.apache.org>
In-Reply-To: <git-pr-134-orc@git.apache.org>
Subject: [GitHub] orc pull request #134: Orc 17
Content-Type: text/plain
Message-Id: <20170705150045.01A73DFC25@git1-us-west.apache.org>
Date: Wed,  5 Jul 2017 15:00:45 +0000 (UTC)
archived-at: Wed, 05 Jul 2017 15:00:49 -0000

Github user AnatoliShein commented on a diff in the pull request:

    https://github.com/apache/orc/pull/134#discussion_r125668140
  
    --- Diff: c++/src/OrcHdfsFile.cc ---
    @@ -66,22 +64,22 @@ namespace orc {
             options = config->GetOptions();
           }
           hdfs::IoService * io_service = hdfs::IoService::New();
    -      //Wrapping fs into a shared pointer to guarantee deletion
    -      std::shared_ptr<hdfs::FileSystem> fs(hdfs::FileSystem::New(io_service, "", options));
    -      if (!fs) {
    +      //Wrapping file_system into a unique pointer to guarantee deletion
    +      file_system = std::unique_ptr<hdfs::FileSystem>(hdfs::FileSystem::New(io_service, "", options));
    +      if (!file_system) {
    --- End diff --
    
    Yes, unique pointer actually supports this notation (thanks to [operator bool](http://en.cppreference.com/w/cpp/memory/unique_ptr/operator_bool))


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---