orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From grundprinzip <...@git.apache.org>
Subject [GitHub] orc pull request #142: [ORC-218] Cache timezone information in the library.
Date Tue, 25 Jul 2017 20:50:56 GMT
GitHub user grundprinzip opened a pull request:

    https://github.com/apache/orc/pull/142

    [ORC-218] Cache timezone information in the library.

    Right now, for every lookup of a timezone, the library will go to
    disk and parse the timezone file. While the results are cached,
    doing these system calls should be avoided in environments with
    restricted system calls.
    
    This patch loads all the time zone files into the binary at
    build time and instead of accessing disk for the TZ
    information will simply load the buffer from memory. In addition,
    this allows the user to compile the library with a static
    timezone to be assumed for local use. This comes in handy to avoid
    yet another set of system calls to assume the local timezone.
    
    The following CMake flags control this feature:
    
      * EMBEDED_TZ_DB - disables this feature if set to OFF
      * STATIC_TZ=Val - sets a specific timezone

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/grundprinzip/orc orc218-tz

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/orc/pull/142.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #142
    
----
commit b87586d3b3b8892c15d04fe6019152deebbb8954
Author: Martin Grund <magrund@amazon.com>
Date:   2017-07-25T20:34:27Z

    [ORC-218] Cache timezone information in the library.
    
    Right now, for every lookup of a timezone, the library will go to
    disk and parse the timezone file. While the results are cached,
    doing these system calls should be avoided in environments with
    restricted system calls.
    
    This patch loads all the time zone files into the binary at
    build time and instead of accessing disk for the TZ
    information will simply load the buffer from memory. In addition,
    this allows the user to compile the library with a static
    timezone to be assumed for local use. This comes in handy to avoid
    yet another set of system calls to assume the local timezone.
    
    The following CMake flags control this feature:
    
      * EMBEDED_TZ_DB - disables this feature if set to OFF
      * STATIC_TZ=Val - sets a specific timezone

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message