orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xndai <...@git.apache.org>
Subject [GitHub] orc pull request #128: ORC-178 Implement Basic C++ Writer and Writer Option
Date Thu, 20 Jul 2017 20:46:09 GMT
Github user xndai commented on a diff in the pull request:

    https://github.com/apache/orc/pull/128#discussion_r128626549
  
    --- Diff: c++/include/orc/Writer.hh ---
    @@ -0,0 +1,294 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +#ifndef ORC_WRITER_HH
    +#define ORC_WRITER_HH
    +
    +#include "orc/Common.hh"
    +#include "orc/orc-config.hh"
    +#include "orc/Type.hh"
    +#include "orc/Vector.hh"
    +
    +#include <memory>
    +#include <string>
    +#include <vector>
    +
    +namespace orc {
    +
    +  // classes that hold data members so we can maintain binary compatibility
    +  struct WriterOptionsPrivate;
    +
    +  enum EncodingStrategy {
    +    EncodingStrategy_SPEED = 0,
    +    EncodingStrategy_COMPRESSION
    +  };
    +
    +  enum CompressionStrategy {
    +    CompressionStrategy_SPEED = 0,
    +    CompressionStrategy_COMPRESSION
    +  };
    +
    +  enum RleVersion {
    +    RleVersion_1,
    +    RleVersion_2
    +  };
    +
    +  class Timezone;
    +
    +  /**
    +   * Options for creating a Writer.
    +   */
    +  class WriterOptions {
    +  private:
    +    ORC_UNIQUE_PTR<WriterOptionsPrivate> privateBits;
    +
    +  public:
    +    WriterOptions();
    +    WriterOptions(const WriterOptions&);
    +    WriterOptions(WriterOptions&);
    +    WriterOptions& operator=(const WriterOptions&);
    +    virtual ~WriterOptions();
    +
    +    /**
    +     * Set the strip size.
    +     */
    +    WriterOptions& setStripeSize(uint64_t size);
    +
    +    /**
    +     * Get the strip size.
    +     * @return if not set, return default value.
    +     */
    +    uint64_t getStripeSize() const;
    +
    +    /**
    +     * Set the block size.
    +     */
    +    WriterOptions& setBlockSize(uint64_t size);
    --- End diff --
    
    Sorry for the wording, I will rename setBlockSize() into setCompressionBlockSize(), and
remove setBufferSize(). Also we don't want the initial stream capacity to be too small otherwise
there will be lots of resizing that involve memory allocation, deallocation and copies. I
would prefer a bigger size than the compression chunk size, e.g. 4M. I will hardcode it for
now, and we can improve later. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message