orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omalley <...@git.apache.org>
Subject [GitHub] orc pull request #135: ORC-204: Update and use CMake ExternalProject_Add to ...
Date Mon, 17 Jul 2017 21:29:50 GMT
Github user omalley commented on a diff in the pull request:

    https://github.com/apache/orc/pull/135#discussion_r127830348
  
    --- Diff: cmake_modules/ThirdpartyToolchain.cmake ---
    @@ -0,0 +1,90 @@
    +set (LZ4_VERSION "1.7.5")
    +set (SNAPPY_VERSION "1.1.3")
    +set (ZLIB_VERSION "1.2.11")
    --- End diff --
    
    Let's put these variable sets in the top level CMakeLists.txt file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message