orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From spasam <...@git.apache.org>
Subject [GitHub] orc pull request #131: ORC-199. Add convert from CSV.
Date Fri, 14 Jul 2017 17:34:21 GMT
Github user spasam commented on a diff in the pull request:

    https://github.com/apache/orc/pull/131#discussion_r127508336
  
    --- Diff: java/tools/src/java/org/apache/orc/tools/convert/ConvertTool.java ---
    @@ -84,7 +225,22 @@ static CommandLine parseOptions(String[] args) throws ParseException
{
         options.addOption(
             Option.builder("o").longOpt("output").desc("Output filename")
                 .hasArg().build());
    -    CommandLine cli = new GnuParser().parse(options, args);
    +    options.addOption(
    --- End diff --
    
    Could you document the default values for these options in the help text?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message