orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From majetideepak <...@git.apache.org>
Subject [GitHub] orc pull request #135: ORC-204: Update and use CMake ExternalProject_Add to ...
Date Fri, 14 Jul 2017 15:49:39 GMT
Github user majetideepak commented on a diff in the pull request:

    https://github.com/apache/orc/pull/135#discussion_r127487866
  
    --- Diff: cmake_modules/ThirdpartyToolchain.cmake ---
    @@ -13,17 +13,18 @@ set (SNAPPY_HOME "${SNAPPY_PREFIX}")
     set (SNAPPY_INCLUDE_DIRS "${SNAPPY_PREFIX}/include")
     set (SNAPPY_STATIC_LIB_NAME snappy)
     set (SNAPPY_STATIC_LIB "${SNAPPY_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}${SNAPPY_STATIC_LIB_NAME}${CMAKE_STATIC_LIBRARY_SUFFIX}")
    -set (SNAPPY_SRC_URL "${CMAKE_SOURCE_DIR}/c++/libs/snappy-${SNAPPY_VERSION}.tar.gz")
    +set (SNAPPY_SRC_URL "https://github.com/google/snappy/releases/download/1.1.4/snappy-${SNAPPY_VERSION}.tar.gz")
    --- End diff --
    
    Good catch! Fixing it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message