orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From majetideepak <...@git.apache.org>
Subject [GitHub] orc pull request #135: ORC-204: Update and use CMake ExternalProject_Add to ...
Date Tue, 11 Jul 2017 23:03:40 GMT
Github user majetideepak commented on a diff in the pull request:

    https://github.com/apache/orc/pull/135#discussion_r126829942
  
    --- Diff: cmake_modules/ThirdpartyToolchain.cmake ---
    @@ -0,0 +1,90 @@
    +set (LZ4_VERSION "1.7.5")
    +set (SNAPPY_VERSION "1.1.3")
    +set (ZLIB_VERSION "1.2.11")
    +set (THIRDPARTY_DIR "${CMAKE_BINARY_DIR}/c++/libs/thirdparty")
    +
    +string(TOUPPER ${CMAKE_BUILD_TYPE} UPPERCASE_BUILD_TYPE)
    +
    +# ----------------------------------------------------------------------
    +# Snappy
    +
    +set (SNAPPY_PREFIX "${THIRDPARTY_DIR}/snappy_ep-install")
    +set (SNAPPY_HOME "${SNAPPY_PREFIX}")
    +set (SNAPPY_INCLUDE_DIRS "${SNAPPY_PREFIX}/include")
    +set (SNAPPY_STATIC_LIB_NAME snappy)
    +set (SNAPPY_STATIC_LIB "${SNAPPY_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}${SNAPPY_STATIC_LIB_NAME}${CMAKE_STATIC_LIBRARY_SUFFIX}")
    +set (SNAPPY_SRC_URL "${CMAKE_SOURCE_DIR}/c++/libs/snappy-${SNAPPY_VERSION}.tar.gz")
    +if (${UPPERCASE_BUILD_TYPE} EQUAL "RELEASE")
    +   set (SNAPPY_CXXFLAGS "CXXFLAGS='-DNDEBUG -O2'")
    +endif ()
    +
    +ExternalProject_Add (snappy_ep
    +  CONFIGURE_COMMAND ./configure "--prefix=${SNAPPY_PREFIX}" ${SNAPPY_CXXFLAGS}
    +  BUILD_IN_SOURCE 1
    +  BUILD_COMMAND ${MAKE}
    +  INSTALL_DIR ${SNAPPY_PREFIX}
    +  URL ${SNAPPY_SRC_URL}
    --- End diff --
    
    +1. I mentioned using HTTP URL(download the tar files) as future work because I wasn't
sure of its impact on current users. I will update to use URLs in this patch if there are
no concerns.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message