orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jamesclampffer <...@git.apache.org>
Subject [GitHub] orc pull request #134: Orc 17
Date Thu, 06 Jul 2017 21:12:06 GMT
Github user jamesclampffer commented on a diff in the pull request:

    https://github.com/apache/orc/pull/134#discussion_r126017188
  
    --- Diff: c++/libs/libhdfspp/CMakeLists.txt ---
    @@ -0,0 +1,248 @@
    +#
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements.  See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership.  The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License.  You may obtain a copy of the License at
    +#
    +#     http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    +#
    +
    +# If cmake variable HDFSPP_LIBRARY_ONLY is set, then tests, examples, and
    +# tools will not be built. This allows for faster builds of the libhdfspp
    +# library alone, avoids looking for a JDK, valgrind, and gmock, and
    +# prevents the generation of multiple binaries that might not be relevant
    +# to other projects during normal use.
    +# Example of cmake invocation with HDFSPP_LIBRARY_ONLY enabled:
    +# cmake -DHDFSPP_LIBRARY_ONLY=1
    +
    +project (libhdfspp)
    +
    +cmake_minimum_required(VERSION 2.8)
    +
    +enable_testing()
    +include (CTest)
    +SET(CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/CMake" ${CMAKE_MODULE_PATH})
    +
    +# If there's a better way to inform FindCyrusSASL.cmake, let's make this cleaner:
    +SET(CMAKE_PREFIX_PATH "${CMAKE_PREFIX_PATH};${CYRUS_SASL_DIR};${GSASL_DIR}")
    +
    +find_package(Doxygen)
    +find_package(OpenSSL REQUIRED)
    +find_package(Protobuf REQUIRED)
    +find_package(CyrusSASL)
    +find_package(GSasl)
    --- End diff --
    
    I think you're going to need a flag to make sure it doesn't attempt to find and link against
GSasl since the Apache and GPL licenses aren't compatible.  Eventually GSasl will be removed
from libhdfs++ for the same reason.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message