orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jamesclampffer <...@git.apache.org>
Subject [GitHub] orc pull request #134: Orc 17
Date Thu, 06 Jul 2017 19:29:41 GMT
Github user jamesclampffer commented on a diff in the pull request:

    https://github.com/apache/orc/pull/134#discussion_r125994365
  
    --- Diff: c++/src/OrcHdfsFile.cc ---
    @@ -34,15 +34,13 @@
     #include "common/hdfs_configuration.h"
     #include "common/configuration_loader.h"
     
    -#define BUF_SIZE 1048576 //1 MB
    -
     namespace orc {
     
       class HdfsFileInputStream : public InputStream {
    --- End diff --
    
    For a mock that does real network stuff libhdfs++ uses the C++/JVM bindings over the minidfscluster
(java namenode and datanode in a single process) for its unit tests.  That seems like a very
large dependency to bring into this project.  It'd be possible to write a mock that goes over
TCP in C/C++, I can think of 2 ways:
    1) Capture network traffic of a read with tcpdump/wireshark for a given request and send
the response back.  This would be really brittle if IO request sizes changed and pretty ugly
to store a bunch of binary data.
    2) Implement at least some of the server side HDFS RPC protocol and DataTransferProtocol
to make a mock namenode and datanode.  This is possible but would be a considerable amount
of work that wouldn't be as useful for libhdfs++ since it already has the minidfscluster.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message