orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xndai <...@git.apache.org>
Subject [GitHub] orc pull request #134: Orc 17
Date Wed, 05 Jul 2017 18:58:27 GMT
Github user xndai commented on a diff in the pull request:

    --- Diff: c++/src/OrcHdfsFile.cc ---
    @@ -34,15 +34,13 @@
     #include "common/hdfs_configuration.h"
     #include "common/configuration_loader.h"
    -#define BUF_SIZE 1048576 //1 MB
     namespace orc {
       class HdfsFileInputStream : public InputStream {
    --- End diff --
    Does HDFS C++ provide a mocked service interface? My concern is the testability of HdfsFileInputStream.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message