orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From AnatoliShein <...@git.apache.org>
Subject [GitHub] orc pull request #134: Orc 17
Date Wed, 05 Jul 2017 15:21:30 GMT
Github user AnatoliShein commented on a diff in the pull request:

    https://github.com/apache/orc/pull/134#discussion_r125674525
  
    --- Diff: c++/src/OrcHdfsFile.cc ---
    @@ -34,15 +34,13 @@
     #include "common/hdfs_configuration.h"
     #include "common/configuration_loader.h"
     
    -#define BUF_SIZE 1048576 //1 MB
    -
     namespace orc {
     
       class HdfsFileInputStream : public InputStream {
    --- End diff --
    
    I don't currently have the UTs for this class because to test it we need a hadoop cluster,
and in order to fire one up we would need to bring the entire hadoop tree into ORC (which
is actually much larger than ORC), and it can make things very heavy.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message