orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From spasam <...@git.apache.org>
Subject [GitHub] orc pull request #130: Fix timestamp pattern and added new test
Date Wed, 21 Jun 2017 19:00:14 GMT
Github user spasam commented on a diff in the pull request:

    https://github.com/apache/orc/pull/130#discussion_r123337668
  
    --- Diff: java/tools/src/java/org/apache/orc/tools/json/JsonSchemaFinder.java ---
    @@ -58,7 +58,7 @@
       private static final Pattern TIMESTAMP_PATTERN =
           Pattern.compile("^[\"]?([0-9]{4}[-/][0-9]{2}[-/][0-9]{2})[T ]" +
               "([0-9]{2}:[0-9]{2}:[0-9]{2})" +
    -          "(([ ][-+]?[0-9]{2}([:][0-9]{2})?)|Z)?[\"]?$");
    +          "(([ ]?[-+]?[0-9]{2}([:][0-9]{2})?)|Z)?[\"]?$");
    --- End diff --
    
    @omalley Good catch. Let me tweak this!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message