orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omalley <...@git.apache.org>
Subject [GitHub] orc pull request #132: ORC-202. Add writer implementation enum to file forma...
Date Fri, 16 Jun 2017 19:17:19 GMT
Github user omalley commented on a diff in the pull request:

    https://github.com/apache/orc/pull/132#discussion_r122514685
  
    --- Diff: java/core/src/test/org/apache/orc/TestVectorOrcFile.java ---
    @@ -3039,9 +3039,45 @@ public void testExpansion() throws Exception {
     
       @Test
       public void testWriterVersion() throws Exception {
    -    assertEquals(OrcFile.WriterVersion.FUTURE, OrcFile.WriterVersion.from(99));
    -    assertEquals(OrcFile.WriterVersion.ORIGINAL, OrcFile.WriterVersion.from(0));
    -    assertEquals(OrcFile.WriterVersion.HIVE_4243, OrcFile.WriterVersion.from(2));
    +    // test writer implementation serialization
    +    assertEquals(OrcFile.WriterImplementation.ORC_JAVA,
    +        OrcFile.WriterImplementation.from(0));
    +    assertEquals(OrcFile.WriterImplementation.ORC_CPP,
    +        OrcFile.WriterImplementation.from(1));
    +    assertEquals(OrcFile.WriterImplementation.PRESTO,
    +        OrcFile.WriterImplementation.from(2));
    +    assertEquals(OrcFile.WriterImplementation.UNKNOWN,
    +        OrcFile.WriterImplementation.from(99));
    +
    +    // test writer version serialization
    +    assertEquals(OrcFile.WriterVersion.FUTURE,
    +        OrcFile.WriterVersion.from(OrcFile.WriterImplementation.ORC_JAVA, 99));
    +    assertEquals(OrcFile.WriterVersion.ORIGINAL,
    +        OrcFile.WriterVersion.from(OrcFile.WriterImplementation.ORC_JAVA, 0));
    +    assertEquals(OrcFile.WriterVersion.HIVE_4243,
    +        OrcFile.WriterVersion.from(OrcFile.WriterImplementation.ORC_JAVA, 2));
    +    assertEquals(OrcFile.WriterVersion.FUTURE,
    +        OrcFile.WriterVersion.from(OrcFile.WriterImplementation.ORC_CPP, 99));
    +    assertEquals(OrcFile.WriterVersion.ORC_CPP_ORIGINAL,
    +        OrcFile.WriterVersion.from(OrcFile.WriterImplementation.ORC_CPP, 0));
    +    assertEquals(OrcFile.WriterVersion.ORC_CPP_ORIGINAL,
    --- End diff --
    
    Sure


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message