orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dain <...@git.apache.org>
Subject [GitHub] orc pull request #132: ORC-202. Add writer implementation enum to file forma...
Date Fri, 16 Jun 2017 18:43:42 GMT
Github user dain commented on a diff in the pull request:

    https://github.com/apache/orc/pull/132#discussion_r122507019
  
    --- Diff: proto/orc_proto.proto ---
    @@ -221,15 +227,29 @@ message PostScript {
       //   [0, 12] = Hive 0.12
       repeated uint32 version = 4 [packed = true];
       optional uint64 metadataLength = 5;
    -  // Version of the writer:
    -  //   0 (or missing) = original
    +
    +  // The version of the writer that wrote the file. This number is
    +  // updated when we make fixes or large changes to the writer so that
    +  // readers can detect whether a given bug is present in the data.
    +  // These numbers are assigned from 0 per a writer.
    +  //
    +  // Version of the ORC Java writer:
    +  //   0 = original
       //   1 = HIVE-8732 fixed
       //   2 = HIVE-4243 fixed
       //   3 = HIVE-12055 fixed
       //   4 = HIVE-13083 fixed
       //   5 = ORC-101 fixed
       //   6 = ORC-135 fixed
    +  //
    +  // Version of the ORC C++ writer:
    +  //   0 = original
    --- End diff --
    
    We likely need to start these with version 6 (maybe jump to 10) so that old readers don't
think this is one of the over versions of the ORC_JAVA writer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message