orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From majetideepak <...@git.apache.org>
Subject [GitHub] orc pull request #128: ORC-178 Implement Basic C++ Writer and Writer Option
Date Tue, 06 Jun 2017 21:20:22 GMT
Github user majetideepak commented on a diff in the pull request:

    https://github.com/apache/orc/pull/128#discussion_r119640657
  
    --- Diff: c++/include/orc/OrcFile.hh ---
    @@ -119,6 +120,17 @@ namespace orc {
        * @param path the name of the file in the local file system
        */
       ORC_UNIQUE_PTR<OutputStream> writeLocalFile(const std::string& path);
    +
    +  /**
    +   * Create a writer to write the ORC file.
    +   * @param type the type of data to be written
    +   * @param stream the stream to write to
    +   * @param options the options for writing the file
    +   */
    +  ORC_UNIQUE_PTR<Writer> createWriter(
    +                                      const Type& type,
    +                                      OutputStream * stream,
    --- End diff --
    
    remove space `OutputStream*`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message