Return-Path: <dev-return-934-archive-asf-public=cust-asf.ponee.io@orc.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 93A5F200C72
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri, 12 May 2017 19:28:20 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 92281160BB8; Fri, 12 May 2017 17:28:20 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 0AAF4160BA8
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 12 May 2017 19:28:19 +0200 (CEST)
Received: (qmail 72198 invoked by uid 500); 12 May 2017 17:28:19 -0000
Mailing-List: contact dev-help@orc.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@orc.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@orc.apache.org>
List-Post: <mailto:dev@orc.apache.org>
List-Id: <dev.orc.apache.org>
Reply-To: dev@orc.apache.org
Delivered-To: mailing list dev@orc.apache.org
Received: (qmail 72186 invoked by uid 99); 12 May 2017 17:28:18 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 May 2017 17:28:18 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id D4D99DFE34; Fri, 12 May 2017 17:28:18 +0000 (UTC)
From: wgtmac <git@git.apache.org>
To: dev@orc.apache.org
Reply-To: dev@orc.apache.org
References: <git-pr-120-orc@git.apache.org>
In-Reply-To: <git-pr-120-orc@git.apache.org>
Subject: [GitHub] orc issue #120: ORC-184: Refactor ColumnStatistics classes for writer
Content-Type: text/plain
Message-Id: <20170512172818.D4D99DFE34@git1-us-west.apache.org>
Date: Fri, 12 May 2017 17:28:18 +0000 (UTC)
archived-at: Fri, 12 May 2017 17:28:20 -0000

Github user wgtmac commented on the issue:

    https://github.com/apache/orc/pull/120
  
    We are progressively working on moving all the code here. As there is a big gap between the current code and our code, it is not possible to create a PR for ColumnWriter right now. 
    
    This PR is not a final decision, but a piece of code to show our ideas and introduce the discussion as we actually need some sort of ColumnStatistics class to act as the base class in the ColumnWriter implementation. To use your InternalStatisticsImpl<Type>, I have following thoughts:
    1) InternalStatisticsImpl<Type> is an implementation class, so the interface functions like increase, merge, reset, etc. should still be defined in a base class somewhere;
    2) We can implement ColumnWriter class using templates as well to adopt InternalStatisticsImpl<Type>; but ColumnWriter and ColumnStatistics are slightly different since ColumnWriter has more types and less common code, so I doubt template is not a good choice for ColumnWriter class.
    3) BTW, I really appreciate your refactoring in your PR @majetideepak. I would like to add our code based on your changes. Before that, we have to achieve a consensus on which class is the best choice of the base class in ColumnWriter implementation (like the ColumnStatisticsImpl on the java side). In our design, it is ColumnStatistics itself.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---