Mailing-List: contact dev-help@orc.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@orc.apache.org
From: omalley <git@git.apache.org>
To: dev@orc.apache.org
Reply-To: dev@orc.apache.org
References: <git-pr-111-orc@git.apache.org>
In-Reply-To: <git-pr-111-orc@git.apache.org>
Subject: [GitHub] orc issue #111: ORC-173: [C++] Expose Indexes as API
Content-Type: text/plain
Message-Id: <20170510204544.8D74BE00A3@git1-us-west.apache.org>
Date: Wed, 10 May 2017 20:45:44 +0000 (UTC)
archived-at: Wed, 10 May 2017 20:45:47 -0000

Github user omalley commented on the issue:

    https://github.com/apache/orc/pull/111
  
    * You've introduced a trailing space in FileStatistics.cc.
    * It would be good if you switched to using getopt_long in FileStatistics, like we did in FileMetadata.cc.
    * Since you added a new example file, you should add it to TestMatch.cc and make an expected file for it.
    * Please keep your column width to 100 characters.
    * You should remove min & max from string, date, and decimal statistics for files before HIVE-8732.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---