Return-Path: <dev-return-896-archive-asf-public=cust-asf.ponee.io@orc.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 9612A200C68
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed,  3 May 2017 19:42:39 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 94966160BB5; Wed,  3 May 2017 17:42:39 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id D1F06160BA1
	for <archive-asf-public@cust-asf.ponee.io>; Wed,  3 May 2017 19:42:38 +0200 (CEST)
Received: (qmail 66508 invoked by uid 500); 3 May 2017 17:42:38 -0000
Mailing-List: contact dev-help@orc.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@orc.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@orc.apache.org>
List-Post: <mailto:dev@orc.apache.org>
List-Id: <dev.orc.apache.org>
Reply-To: dev@orc.apache.org
Delivered-To: mailing list dev@orc.apache.org
Received: (qmail 66491 invoked by uid 99); 3 May 2017 17:42:37 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 May 2017 17:42:37 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id AEBC8DFBC7; Wed,  3 May 2017 17:42:37 +0000 (UTC)
From: wgtmac <git@git.apache.org>
To: dev@orc.apache.org
Reply-To: dev@orc.apache.org
References: <git-pr-115-orc@git.apache.org>
In-Reply-To: <git-pr-115-orc@git.apache.org>
Subject: [GitHub] orc pull request #115: ORC-183: Add a method in Type to build type
Content-Type: text/plain
Message-Id: <20170503174237.AEBC8DFBC7@git1-us-west.apache.org>
Date: Wed,  3 May 2017 17:42:37 +0000 (UTC)
archived-at: Wed, 03 May 2017 17:42:39 -0000

Github user wgtmac commented on a diff in the pull request:

    https://github.com/apache/orc/pull/115#discussion_r114607793
  
    --- Diff: c++/src/TypeImpl.cc ---
    @@ -491,4 +491,190 @@ namespace orc {
         return std::unique_ptr<Type>(result);
       }
     
    +  Type * Type::buildTypeFromString(const std::string& input) {
    --- End diff --
    
    Make sense. I will do the refactoring soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---