orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xndai <...@git.apache.org>
Subject [GitHub] orc pull request #128: ORC-178 Implement Basic C++ Writer and Writer Option
Date Wed, 24 May 2017 22:10:07 GMT
GitHub user xndai opened a pull request:

    https://github.com/apache/orc/pull/128

    ORC-178 Implement Basic C++ Writer and Writer Option

    1. Add basic Writer and WriterOption
    2. Add StructColumnWriter and IntegerColumnWriter. With them, we will be
    able to write a complete ORC file that contains only int columns. To
    limit the scope of this change, we will add more column writers later.
    3. Add a base class for column statistics impl classes. This
    is to be used by the base class of ColumnWriter so we don't have to
    duplicate a bunch of logics everywhere.
    4. Right now the UTs are pretty primative. We will add more UTs
    (especially for stats and index) as we are adding more column writers.
    At this moment, it's really hard to extract more UTs from our code base
    without intorducing additional column writers.
    
    Change-Id: I694dda600136e5d285e70a8124aa1cc334f4ef14

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xndai/orc dev_writer

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/orc/pull/128.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #128
    
----
commit 013d18dc459f75763fa1951717c9d3624ab38519
Author: Xiening.Dai <xiening.dai@alibaba-inc.com>
Date:   2017-05-24T22:01:52Z

    ORC-178 Implement Basic C++ Writer and Writer Option
    
    1. Add basic Writer and WriterOption
    2. Add StructColumnWriter and IntegerColumnWriter. With them, we will be
    able to write a complete ORC file that contains only int columns. To
    limit the scope of this change, we will add more column writers later.
    3. Add a base class for column statistics impl classes. This
    is to be used by the base class of ColumnWriter so we don't have to
    duplicate a bunch of logics everywhere.
    4. Right now the UTs are pretty primative. We will add more UTs
    (especially for stats and index) as we are adding more column writers.
    At this moment, it's really hard to extract more UTs from our code base
    without intorducing additional column writers.
    
    Change-Id: I694dda600136e5d285e70a8124aa1cc334f4ef14

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message