orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From majetideepak <...@git.apache.org>
Subject [GitHub] orc pull request #126: ORC-191 Implement RLE v1 encoder
Date Tue, 23 May 2017 00:29:10 GMT
Github user majetideepak commented on a diff in the pull request:

    https://github.com/apache/orc/pull/126#discussion_r117873593
  
    --- Diff: c++/src/RLEv1.cc ---
    @@ -26,8 +26,173 @@
     namespace orc {
     
     const uint64_t MINIMUM_REPEAT = 3;
    +const uint64_t MAXIMUM_REPEAT = 127 + MINIMUM_REPEAT;
    +
     const uint64_t BASE_128_MASK = 0x7f;
     
    +const int MAX_DELTA = 127;
    +const int MIN_DELTA = -128;
    +const int MAX_LITERAL_SIZE = 128;
    +
    +RleEncoderV1::RleEncoderV1(
    +                          std::unique_ptr<BufferedOutputStream> outStream,
    +                          bool hasSigned):
    +                          outputStream(std::move(outStream)) {
    +  isSigned = hasSigned;
    +  literals = new int64_t[MAX_LITERAL_SIZE];
    --- End diff --
    
    use `std::vector<int64_t>` literals_buf as a buffer instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message