orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From majetideepak <...@git.apache.org>
Subject [GitHub] orc pull request #123: ORC-184: Refactor ColumnStatistics classes for writer
Date Sat, 20 May 2017 14:03:38 GMT
Github user majetideepak commented on a diff in the pull request:

    https://github.com/apache/orc/pull/123#discussion_r117610190
  
    --- Diff: c++/include/orc/Vector.hh ---
    @@ -194,6 +194,14 @@ namespace orc {
         int32_t scale;
       };
     
    +  /**
    +   * Compares two decimals
    +   * @param decimal1 1st decimal to compare
    +   * @param decimal2 2nd decimal to compare
    +   * @return true is decimal1 is less than decimal2; otherwise false
    +   */
    +  bool operator<(Decimal decimal1, Decimal decimal2);
    --- End diff --
    
    Libraries usually don't define these operators in the public API.
    It is also odd that we only define one operator and not the other operators.
    All other non-primitive types don't have these operators defined as well. It looks odd
just to add this one. Can we just use `compare(Decimal, Decimal)` api inside? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message