orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From majetideepak <...@git.apache.org>
Subject [GitHub] orc pull request #122: ORC-192 Implement zlib compresion stream
Date Sat, 20 May 2017 13:54:37 GMT
Github user majetideepak commented on a diff in the pull request:

    https://github.com/apache/orc/pull/122#discussion_r117609935
  
    --- Diff: c++/src/Compression.hh ---
    @@ -20,9 +20,15 @@
     #define ORC_COMPRESSION_HH
     
     #include "io/InputStream.hh"
    +#include "io/OutputStream.hh"
     
     namespace orc {
     
    +  enum CompressionStrategy {
    +    CompressionStrategy_SPEED = 0,
    --- End diff --
    
    Can you add a `CompressionStrategy_DEFAULT` here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message