orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wgtmac <...@git.apache.org>
Subject [GitHub] orc pull request #123: ORC-184: Refactor ColumnStatistics classes for writer
Date Fri, 19 May 2017 03:30:30 GMT
Github user wgtmac commented on a diff in the pull request:

    https://github.com/apache/orc/pull/123#discussion_r117397315
  
    --- Diff: c++/include/orc/Statistics.hh ---
    @@ -392,7 +392,14 @@ namespace orc {
         virtual uint32_t getNumberOfRowIndexStats(uint32_t columnId) const = 0;
       };
     
    -
    +  /**
    +   * Create ColumnStatistics for writers
    +   * @param type of column
    +   * @param enableStringComparison whether enable string columns comparision
    +   * @return ColumnStatistics instances
    +   */
    +  std::unique_ptr<ColumnStatistics> createColumnStatistics(
    --- End diff --
    
    Make sense. I will move it to src/Statistics.hh


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message