orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From majetideepak <...@git.apache.org>
Subject [GitHub] orc issue #120: ORC-184: Refactor ColumnStatistics classes for writer
Date Fri, 12 May 2017 16:08:36 GMT
Github user majetideepak commented on the issue:

    https://github.com/apache/orc/pull/120
  
    You are right that we cannot make  [Type]ColumnStatisticsImpl inherit ColumnStatisticsImpl.
That is why I introduced `InternalStatisticsImpl` in ORC-185.
    With that, you will just use `InternalStatisticsImpl<Type>` in your templated [Type]ColumnWriterImpl.

    I guess without the design for the ColumnWriter, it is hard to discuss at this point.
    
    Can you open a separate PR for your ColumnWrite code? Things will get more clear then.
    We can converge on the necessary overall changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message