orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xndai <...@git.apache.org>
Subject [GitHub] orc pull request #116: ORC-185: [C++] Simplify Statististics Implementation
Date Tue, 09 May 2017 21:23:38 GMT
Github user xndai commented on a diff in the pull request:

    https://github.com/apache/orc/pull/116#discussion_r115606228
  
    --- Diff: c++/src/Statistics.hh ---
    @@ -41,49 +41,181 @@ namespace orc {
       };
     
     /**
    + * Internal Statistics Implementation
    + */
    +
    +  template <typename T>
    +  class InternalStatisticsImpl {
    +  private:
    +    bool hasNull_;
    --- End diff --
    
    Personally I don't have any problem with the current style. I don't even notice the inconsistency
(should have pay more attentions to style, :)). But to me, missing writer is a big functionality
gap that needs to be filled in quickly.
    
    Having said that I think this is eventually a call from @omalley and other major committers.
If we really want to enforce a new style, we should always update the existing code first
before adding new codes with new style. Otherwise the code base is going to look even worse
until we fix everything.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message