orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wgtmac <...@git.apache.org>
Subject [GitHub] orc pull request #115: ORC-183: Add a method in Type to build type
Date Wed, 03 May 2017 17:42:37 GMT
Github user wgtmac commented on a diff in the pull request:

    https://github.com/apache/orc/pull/115#discussion_r114607793
  
    --- Diff: c++/src/TypeImpl.cc ---
    @@ -491,4 +491,190 @@ namespace orc {
         return std::unique_ptr<Type>(result);
       }
     
    +  Type * Type::buildTypeFromString(const std::string& input) {
    --- End diff --
    
    Make sense. I will do the refactoring soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message