orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wgtmac <...@git.apache.org>
Subject [GitHub] orc issue #116: ORC-185: [C++] Simplify Statististics Implementation
Date Tue, 02 May 2017 23:27:32 GMT
Github user wgtmac commented on the issue:

    https://github.com/apache/orc/pull/116
  
    Overall the PIMPL looks nicer than the current implementation. My main concern for using
templates is that we need to compare & update values of different types, merge ColumnStatistics,
and transform to protobuf version for implementing writers and using templates may not help
in this case. It means we still need to do template specialization for different types like
Date, Timestamp, Decimal, etc. if we want to let class ColumnStatistics to handle the update
(e.g. use ColumnStatistics<T>::update(T value) to update min/max for type T). Otherwise
we may need to let specific ColumnWriters to be responsible for update (e.g. DecimalColumnWriter
to compare min/max of decimal values and then use setMax/setMin of ColumnStatistics<Decimal>
to update the values).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message