orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wgtmac <...@git.apache.org>
Subject [GitHub] orc pull request #111: ORC-173: [C++] Expose Indexes as API
Date Tue, 02 May 2017 16:49:16 GMT
Github user wgtmac commented on a diff in the pull request:

    https://github.com/apache/orc/pull/111#discussion_r114367188
  
    --- Diff: c++/src/Statistics.hh ---
    @@ -605,6 +676,43 @@ namespace orc {
         }
       };
     
    +  class StripeStatisticsImpl: public StripeStatistics {
    +  private:
    +    std::unique_ptr<StatisticsImpl> columnStats;
    +    std::vector<std::vector<std::unique_ptr<const ColumnStatistics> >
> rowIndexStats;
    --- End diff --
    
    auto_ptr is not copy-assignable so we can't create a container of auto_ptr. This is the
problem.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message