orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wgtmac <...@git.apache.org>
Subject [GitHub] orc pull request #110: ORC-87: [C++] Handle missing timezone conversion for ...
Date Tue, 02 May 2017 04:55:01 GMT
Github user wgtmac commented on a diff in the pull request:

    --- Diff: c++/src/Reader.cc ---
    @@ -526,16 +526,22 @@ namespace orc {
         if (metadata.get() == nullptr) {
           throw std::logic_error("No stripe statistics in file");
    +    auto currentStripeInfo = footer->stripes(static_cast<int>(stripeIndex));
    --- End diff --
    Should we consider some older compliers which don't support c++11 very well? I don't see
anywhere else is using keyword auto.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message