Return-Path: <dev-return-832-archive-asf-public=cust-asf.ponee.io@orc.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id DB3D6200C5B
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu, 27 Apr 2017 21:56:46 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id DA050160BBE; Thu, 27 Apr 2017 19:56:46 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 5C3A9160BB2
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 27 Apr 2017 21:56:46 +0200 (CEST)
Received: (qmail 83252 invoked by uid 500); 27 Apr 2017 19:56:45 -0000
Mailing-List: contact dev-help@orc.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@orc.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@orc.apache.org>
List-Post: <mailto:dev@orc.apache.org>
List-Id: <dev.orc.apache.org>
Reply-To: dev@orc.apache.org
Delivered-To: mailing list dev@orc.apache.org
Received: (qmail 82978 invoked by uid 99); 27 Apr 2017 19:56:43 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Apr 2017 19:56:43 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 354B0E10BF; Thu, 27 Apr 2017 19:56:43 +0000 (UTC)
From: majetideepak <git@git.apache.org>
To: dev@orc.apache.org
Reply-To: dev@orc.apache.org
References: <git-pr-113-orc@git.apache.org>
In-Reply-To: <git-pr-113-orc@git.apache.org>
Subject: [GitHub] orc pull request #113: ORC-176: Refactor common classes for writer and reade...
Content-Type: text/plain
Message-Id: <20170427195643.354B0E10BF@git1-us-west.apache.org>
Date: Thu, 27 Apr 2017 19:56:43 +0000 (UTC)
archived-at: Thu, 27 Apr 2017 19:56:47 -0000

Github user majetideepak commented on a diff in the pull request:

    https://github.com/apache/orc/pull/113#discussion_r113729558
  
    --- Diff: c++/include/orc/Common.hh ---
    @@ -0,0 +1,167 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +#ifndef ORC_COMMON_HH
    +#define ORC_COMMON_HH
    +
    +#include "orc/Vector.hh"
    +#include "orc/Type.hh"
    +#include "Exceptions.hh"
    +#include "wrap/orc-proto-wrapper.hh"
    +
    +#include <string>
    +
    +namespace orc {
    +  enum CompressionKind {
    --- End diff --
    
    Move to `orc/Type.hh`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---