orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wgtmac <...@git.apache.org>
Subject [GitHub] orc issue #113: ORC-176: Refactor common classes for writer and reader
Date Sat, 29 Apr 2017 00:24:16 GMT
Github user wgtmac commented on the issue:

    https://github.com/apache/orc/pull/113
  
    @majetideepak I would absolutely support 2 and 3 as it will definitely improve the code
quality and readability. As for 1, I would say let's do it in caution. At present we have
classes like ColumnStatistics and ColumnReader which have a one-to-many inheritance relation.
Particularly, class ColumnStatistics has many duplicate code which takes more effort for use
when we were adding functions to it for implementing writer. This can be improved first.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message