orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From majetideepak <...@git.apache.org>
Subject [GitHub] orc pull request #113: ORC-176: Refactor common classes for writer and reade...
Date Thu, 27 Apr 2017 19:56:43 GMT
Github user majetideepak commented on a diff in the pull request:

    https://github.com/apache/orc/pull/113#discussion_r113784499
  
    --- Diff: c++/include/orc/Statistics.hh ---
    @@ -37,12 +37,76 @@ namespace orc {
          * of rows because of NULL values and repeated values.
          * @return the number of values
          */
    -    virtual uint64_t getNumberOfValues() const = 0;
    +    virtual uint64_t getNumberOfValues() const {
    +      return valueCount;
    +    }
    +
    +    /**
    +     * Set the number of values in this column
    +     * @param newValueCount new number of values to be set
    +     */
    +    virtual void setNumberOfValues(uint64_t newValueCount) {
    --- End diff --
    
    Are these and the below methods required in the public API?
    I think they belong to the Impl classes in `c++/src/Statistics.hh`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message