orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wgtmac <...@git.apache.org>
Subject [GitHub] orc pull request #111: ORC-173: [C++] Expose Indexes as API
Date Thu, 27 Apr 2017 18:54:39 GMT
Github user wgtmac commented on a diff in the pull request:

    https://github.com/apache/orc/pull/111#discussion_r113775214
  
    --- Diff: c++/include/orc/Statistics.hh ---
    @@ -321,6 +321,32 @@ namespace orc {
          * @return maximum value
          */
         virtual int64_t getMaximum() const = 0;
    +
    +    /**
    +     * check whether column has a lowerBound
    +     * @return true if column has a lowerBound
    +     */
    +    virtual bool hasLowerBound() const = 0;
    --- End diff --
    
    I saw these lines of changes are also in ORC-87. Is it a good idea to remove them here
to make this change more concise?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message