orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omalley <...@git.apache.org>
Subject [GitHub] orc pull request #110: ORC-87: [C++] Handle missing timezone conversion for ...
Date Tue, 25 Apr 2017 20:28:36 GMT
Github user omalley commented on a diff in the pull request:

    https://github.com/apache/orc/pull/110#discussion_r113301529
  
    --- Diff: c++/src/Statistics.hh ---
    @@ -23,10 +23,17 @@
     #include "orc/OrcFile.hh"
     #include "orc/Reader.hh"
     
    +#include "Timezone.hh"
     #include "TypeImpl.hh"
     
     namespace orc {
     
    +  struct StatContext {
    +    bool correctStats;
    +    const Timezone* writerTimezone;
    +    StatContext() : correctStats(false), writerTimezone(NULL) {}
    --- End diff --
    
    Shouldn't the constructor take the correctStats and writerTimezone and make them const?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message