orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From prasanthj <...@git.apache.org>
Subject [GitHub] orc pull request #102: ORC-166 : add codec pool to ORC; make sure end is cal...
Date Tue, 21 Mar 2017 07:45:34 GMT
Github user prasanthj commented on a diff in the pull request:

    https://github.com/apache/orc/pull/102#discussion_r107086052
  
    --- Diff: java/core/src/java/org/apache/orc/impl/HadoopShimsCurrent.java ---
    @@ -33,31 +34,62 @@
      */
     public class HadoopShimsCurrent implements HadoopShims {
     
    -  private static class DirectDecompressWrapper implements DirectDecompressor {
    -    private final org.apache.hadoop.io.compress.DirectDecompressor root;
    +  private static class SnappyDirectDecompressWrapper implements DirectDecompressor {
    --- End diff --
    
    Is this change required? I don't see any change that require having separate Snappy and
Zlib wrappers. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message