orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From majetideepak <...@git.apache.org>
Subject [GitHub] orc pull request #74: ORC-123: Fix memory leaks in ToolTest.cc
Date Fri, 16 Dec 2016 18:48:26 GMT
Github user majetideepak commented on a diff in the pull request:

    https://github.com/apache/orc/pull/74#discussion_r92864389
  
    --- Diff: tools/test/ToolTest.cc ---
    @@ -82,8 +83,10 @@ int runProgram(const std::vector<std::string>& command,
                    std::string &err) {
     
       // create temporary filenames for stdout and stderr
    -  char *stdoutName = strdup("/tmp/orc-test-stdout-XXXXXXXX");
    -  char *stderrName = strdup("/tmp/orc-test-stderr-XXXXXXXX");
    --- End diff --
    
    `strdup` does a malloc internally and must be freed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message