orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From majetideepak <...@git.apache.org>
Subject [GitHub] orc issue #41: ORC-58: Move code for reading rows from Reader to RowReader
Date Tue, 13 Dec 2016 20:25:50 GMT
Github user majetideepak commented on the issue:

    https://github.com/apache/orc/pull/41
  
    Included review comments.
    This patch is huge because I split the monolithic Reader.cc into various files
    - Reader.hh/Reader.cc: ReaderImpl and RowReaderImpl
    - Statistics.hh/Statistics.cc: ColumnStatisticsImpl, StatisticsImpl, Type*StatisticsImpl
    - StripeStream.hh/StripeStream.cc: StripeStreamsImpl, StreamInformationImpl, StripeInformationImpl
    - Options.hh: ReaderOptions, RowReaderOptions
    
    @omalley any feedback ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message