orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omalley <...@git.apache.org>
Subject [GitHub] orc pull request #60: ORC-101 fix broken encoding for string and decimal blo...
Date Thu, 22 Sep 2016 19:11:51 GMT
Github user omalley commented on a diff in the pull request:

    https://github.com/apache/orc/pull/60#discussion_r80114710
  
    --- Diff: java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java ---
    @@ -1168,8 +1193,9 @@ public OrcIndex readRowIndex(int stripeIndex, boolean[] included,
           sargColumns = sargColumns == null ?
               (sargApp == null ? null : sargApp.sargColumns) : sargColumns;
         }
    -    return dataReader.readRowIndex(stripe, stripeFooter, included, indexes, sargColumns,
    -        bloomFilterIndex);
    +    return dataReader.readRowIndex(stripe, evolution.getFileType(0), stripeFooter,
    --- End diff --
    
    Actually RecordReaderImpl.mapSargColumnsToOrcInternalColIdx already maps column names
to the physical file column ids. It handles ACID files by looking for the field names in row
field instead of the root. So at this level, it should be consistently using the file id.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message