orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From prasanthj <...@git.apache.org>
Subject [GitHub] orc pull request #60: ORC-101 fix broken encoding for string and decimal blo...
Date Fri, 16 Sep 2016 02:20:05 GMT
Github user prasanthj commented on a diff in the pull request:

    --- Diff: java/core/src/java/org/apache/orc/impl/WriterImpl.java ---
    @@ -1901,7 +2014,11 @@ void writeBatch(ColumnVector vector, int offset,
               HiveDecimal value = vec.vector[0].getHiveDecimal();
               if (createBloomFilter) {
    -            bloomFilter.addString(value.toString());
    +            String str = value.toString();
    +            if (bloomFilter != null) {
    +              bloomFilter.addString(str);
    --- End diff --
    Can you plz add a comment here for not using UTF-8 for decimals?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message