orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From prasanthj <...@git.apache.org>
Subject [GitHub] orc pull request #60: ORC-101 fix broken encoding for string and decimal blo...
Date Fri, 16 Sep 2016 01:19:00 GMT
Github user prasanthj commented on a diff in the pull request:

    https://github.com/apache/orc/pull/60#discussion_r79093764
  
    --- Diff: java/core/src/java/org/apache/orc/OrcConf.java ---
    @@ -105,6 +105,12 @@
               "dictionary or not will be retained thereafter."),
       BLOOM_FILTER_COLUMNS("orc.bloom.filter.columns", "orc.bloom.filter.columns",
           "", "List of columns to create bloom filters for when writing."),
    +  BLOOM_FILTER_WRITE_VERSION("orc.bloom.filter.write.version",
    +      "orc.bloom.filter.write.version", OrcFile.BloomFilterVersion.UTF8.toString(),
    +      "Which version of the bloom filter should we write."),
    --- End diff --
    
    I see from below to provide the option of writing both default and utf-8 we are using
this config. Can you use enum of "default","utf-8" and add a description saying default will
write both versions. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message