orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omalley <...@git.apache.org>
Subject [GitHub] orc pull request #41: ORC-58: Move code for reading rows from Reader to RowR...
Date Tue, 19 Jul 2016 16:51:04 GMT
Github user omalley commented on a diff in the pull request:

    https://github.com/apache/orc/pull/41#discussion_r71377966
  
    --- Diff: c++/include/orc/Reader.hh ---
    @@ -645,7 +645,72 @@ namespace orc {
       };
     
       /**
    -   * The interface for reading ORC files.
    +   * The interface for reading rows in ORC files.
    +   * This is an an abstract class that will subclassed as necessary.
    +   */
    +  class RowReader {
    +  public:
    +    virtual ~RowReader();
    +    /**
    +     * Get the selected type of the rows in the file. The file's row type
    +     * is projected down to just the selected columns. Thus, if the file's
    +     * type is struct<col0:int,col1:double,col2:string> and the selected
    +     * columns are "col0,col2" the selected type would be
    +     * struct<col0:int,col2:string>.
    +     * @return the root type
    +     */
    +    virtual const Type& getSelectedType() const = 0;
    +
    +    /**
    +     * Get the selected columns of the file.
    +     */
    +    virtual const std::vector<bool> getSelectedColumns() const = 0;
    +
    --- End diff --
    
    You have some trailing spaces. You can probably configure your IDE to automatically trim
them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message