orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From majetideepak <...@git.apache.org>
Subject [GitHub] orc pull request #41: ORC-58: Move code for reading rows from Reader to RowR...
Date Fri, 15 Jul 2016 19:32:26 GMT
Github user majetideepak commented on a diff in the pull request:

    https://github.com/apache/orc/pull/41#discussion_r71029025
  
    --- Diff: c++/src/Reader.cc ---
    @@ -1108,13 +1107,75 @@ namespace orc {
         // internal methods
         proto::StripeFooter getStripeFooter(const proto::StripeInformation& info);
         void startNextStripe();
    -    void checkOrcVersion();
         void selectType(const Type& type);
    -    void readMetadata() const;
         void updateSelected(const std::list<uint64_t>& fieldIds);
         void updateSelected(const std::list<std::string>& fieldNames);
     
       public:
    +   /**
    +    * Constructor that lets the user specify additional options.
    +    * @param filereader the object to read from
    +    * @param options options for reading
    +    */
    +    RowReaderImpl(const ReaderImpl* filereader,
    --- End diff --
    
    We will have to extend the `Reader` interface with a notion of `metadata`, `ReaderOptions`
etc. to achieve this. I am not sure what the right design choice is here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message