orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omalley <...@git.apache.org>
Subject [GitHub] orc pull request #40: ORC-54: Evolve schemas based on field name rather than...
Date Wed, 06 Jul 2016 17:46:35 GMT
Github user omalley commented on a diff in the pull request:

    https://github.com/apache/orc/pull/40#discussion_r69777633
  
    --- Diff: java/core/src/java/org/apache/orc/impl/ReaderImpl.java ---
    @@ -572,7 +572,14 @@ public RecordReader rows(Options options) throws IOException {
         boolean[] include = options.getInclude();
         // if included columns is null, then include all columns
         if (include == null) {
    -      include = new boolean[types.size()];
    +      int size;
    +      TypeDescription readSchema = options.getSchema();
    +      if (readSchema != null){
    +        size = readSchema.getMaximumId() + 1;
    --- End diff --
    
    I'd suggest doing
    ```
    if (readSchema == null) {
      readSchema = schema;
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message