orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wagnermarkd <...@git.apache.org>
Subject [GitHub] orc pull request #29: ORC-53. Make the complex types Comparable so they can ...
Date Wed, 01 Jun 2016 22:01:37 GMT
Github user wagnermarkd commented on a diff in the pull request:

    https://github.com/apache/orc/pull/29#discussion_r65451326
  
    --- Diff: java/mapreduce/src/test/org/apache/orc/mapred/TestOrcStruct.java ---
    @@ -123,4 +123,18 @@ public void testCompare() {
         assertEquals(1 , left.compareTo(right));
         assertEquals(-1, right.compareTo(left));
       }
    +
    +  @Test
    +  public void testSchemaInCompare() {
    +    TypeDescription leftType = TypeDescription.fromString("struct<s:string,i:int>");
    +    TypeDescription rightType = TypeDescription.fromString("struct<s:string,j:bigint>");
    +    OrcStruct left = new OrcStruct(leftType);
    +    OrcStruct right = new OrcStruct(rightType);
    +    assertEquals(-1, left.compareTo(right));
    +    assertEquals(1, right.compareTo(left));
    +    left.setAllFields(new Text("123"), new IntWritable(123));
    --- End diff --
    
    I checked out your branch and got a compilation error for setAllFields, which was introduced
for ORC-52.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message