Mailing-List: contact dev-help@orc.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@orc.apache.org
From: omalley <git@git.apache.org>
To: dev@orc.apache.org
Reply-To: dev@orc.apache.org
References: <git-pr-23-orc@git.apache.org>
In-Reply-To: <git-pr-23-orc@git.apache.org>
Subject: [GitHub] orc pull request: ORC-1 Import of ORC code from Hive.
Content-Type: text/plain
Message-Id: <20160426164301.C3579DFF30@git1-us-west.apache.org>
Date: Tue, 26 Apr 2016 16:43:01 +0000 (UTC)

Github user omalley commented on the pull request:

    https://github.com/apache/orc/pull/23#issuecomment-214806455
  
    1. You're right that you can't actually pass null in to value. *smile*
    2. I made the accessors public.
    3. I added getters and setters that take the field name.
    4. The input format doesn't need to have a struct as the root type. Look at TestOrcOutputFormat.testLongRoot for an example.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---