orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nahguam <...@git.apache.org>
Subject [GitHub] orc pull request: ORC-1 Import of ORC code from Hive.
Date Wed, 27 Apr 2016 12:55:37 GMT
Github user nahguam commented on the pull request:

    https://github.com/apache/orc/pull/23#issuecomment-215073080
  
    Excellent, Thanks!
    
    I've just been going over all the types and have a few more:
    
    1. `VectorizedRowBatch.toUTF8` appears to be unused
    2. `OrcMap` & `OrcList` - please could the constructors be public?
    3. `OrcList` - please could we have another constructor so we can pass in the initialCapacity
as per `ArrayList`?
    4. `OrcUnion` - please could the class itself and the `set` method be public?
    
    I'm just looking at the Formats/RecordReader/RecordWriter now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message