orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nahguam <...@git.apache.org>
Subject [GitHub] orc pull request: ORC-1 Import of ORC code from Hive.
Date Tue, 26 Apr 2016 15:11:11 GMT
Github user nahguam commented on the pull request:

    https://github.com/apache/orc/pull/23#issuecomment-214777817
  
    Hi, what's the best place for comments?
    
    The diff is too big to comment directly so I'll list a couple here:
    
    1. OrcRecordReader.next L94 - seems to be a dead-end?
    
    2. How is one to use OrcStruct as an end user? getFieldValue and setFieldValue are package
private. Previously you'd access via the StructObjectInspector, but we seem to have no ObjectInspectors
or StructFields.
    
        FileInputFormat.setInputPaths(conf, path);
        OrcInputFormat<OrcStruct> inputFormat = new OrcInputFormat<>();
        InputSplit[] splits = inputFormat.getSplits(conf, 1);
        RecordReader<NullWritable, OrcStruct> recordReader = inputFormat.getRecordReader(splits[0],
conf, null);
    
        NullWritable key = recordReader.createKey();
        OrcStruct value = recordReader.createValue();
    
        while (recordReader.next(key, value)) {
          // How do I interrogate value for it's fields' values?
        }
    
        recordReader.close();
        
    3. Perhaps for another ticket, but it would be nice to have a mechanism to access a struct's
fields by name as well as by index.
    
    4. Is there any particular reason that the value generic type is V extends Writable instead
of OrcStruct?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message