orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omalley <...@git.apache.org>
Subject [GitHub] orc pull request: ORC-46. Reserve CompressionKind values for LZ4 a...
Date Thu, 07 Apr 2016 18:46:44 GMT
Github user omalley commented on the pull request:

    https://github.com/apache/orc/pull/20#issuecomment-207046601
  
    A couple of thoughts:
    * So Presto has a writer now? If so, we should extend the WriterVersion with a new id
for it so that we can handle bugs that are specific to that implementation.
    * I assume you'll follow the same compression block structure that we used with zlib and
snappy. (Three bytes of header followed by the untagged compressed bytes.) I'm very concerned
that we don't break compatibility with the C++ and Java readers.
    * That is *really* cool that there is a pure Java LZO, Snappy, and LZ4 implementation
that is Apache licensed. Does it have a release that is pushed to Maven central?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message